Bug fix: Call ticker.Stop() when aggregator is stopped #269
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
This is a bugfix PR that prevents the aggregator's ticker from being leaked when the statsd client is closed.
Longer version
For reasons that aren't super interesting, we have an app that periodically allocates and closes statsd clients, e.g.
The app does this frequently enough that we discovered a leaked ticker. The DataDog continuous profiler helped zero in on the problem by hinting that the app was spending an increasing number of CPU cycles on
runtime.CheckTimers
andruntime.netpoll
/runtime.epollwait
. For a one-liner change, the effect is pretty outsized! You can spot the difference: